[pulseaudio-discuss] Two small patches for pacat/utf8
Arun Raghavan
arun.raghavan at collabora.co.uk
Tue Oct 11 11:09:10 PDT 2011
On Mon, 2011-10-10 at 09:27 +0200, Maarten Bosmans wrote:
> These two are the result of helping someone on IRC this weekend getting pulse to run on an OpenWRT device.
> If compiled without iconv support, pacat gives an unclear "invalid argument" error.
>
> The first patch addresses the local<->utf8 conversion when iconv is not available. The pa_locale_to_utf8
> change is good, becaus if it happens to be utf8 already, we should just pass it on instead of always
> returning an error (NULL).
> The other way around, pa_utf8_to_locale I'm not so sure about. Do most locales handle pure ascii sensibly?
> I know the european ones do.
>
> The second patch is just an expression of the fail early principle. Makes debugging a bit easier.
>
> Both patches should also go in stable, IMO.
Pulled both, but I'd rather not push to stable right now since there is
some potential for breakage (although the situation *should* be no worse
than it is now on these systems).
Cheers,
Arun
More information about the pulseaudio-discuss
mailing list