[pulseaudio-discuss] [PATCH 04/25] printout pthread id number in pulseaudio log

[Maarten Bosmans]

2011/9/1 Colin Guthrie <gmane at colin.guthr.ie>:
>>> 2) If we can eliminate this information from the main thread (empty
>>> brackets or just remove it altogether), that would reduce most of the
>>> log size increased by this patch.
>>
>> On point 2, do you mean "[pulseaudio] xxxx" should be better changed to
>> "[] xxxx" or "xxxx" instead? I agree it's annoying to see lots of
>> "pulseaudio" messages on the log.
>>
>> I can help to make our debugging life easier. :)

This still needs to be done.

> Just so that work is not duplicated, this is the patch I currently have
> in my "pending" tree for after we reopen master for general feature
> improvements again.

What's up with the first hunk of thread.h?

This approach is quite messy, with all the PA_INVALID_INDEX. I'd
rather see the prototypes of pa_thread_* unchanged and just do a
pa_sprintf_malloc in the calling code, where necessary.

> Col

Maarten