[pulseaudio-discuss] [PATCH] Make sure module-dbus-protocol is loaded after module-default-device-restore

David Henningsson david.henningsson at canonical.com
Wed Sep 14 07:10:32 PDT 2011


On 09/14/2011 03:45 PM, Maarten Bosmans wrote:
> 2011/9/14 David Henningsson<david.henningsson at canonical.com>:
>> Module-dbus-protocol gets the default sink, which sets the default sink
>> if not already set. This is turn makes module-default-device-restore do
>> nothing.
>> To solve the problem, make sure module-default-device-restore is loaded
>> before module-dbus-protocol and not the other way around.
>
> Wouldn't this gloss over the fact the one could reasonably expectation
> that loading a protocol module does not affect the state of the daemon
> other than that (obviously) a module has been added?
>
> I don't believe that module-dbus-protocol should be special in this regard.

Well, I don't like that asking for the default sink turns out actually 
saving a default sink to disk, if nobody has set the default sink 
earlier. But fixing that is more difficult, and once we have the 
priority lists, this will be handled differently and hopefully much 
better. This is more of a quick fix/workaround for v1.0.

Ok to push?

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list