[pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

Colin Guthrie gmane at colin.guthr.ie
Fri Sep 30 03:31:54 PDT 2011


'Twas brillig, and Arun Raghavan at 30/09/11 10:35 did gyre and gimble:
> On Fri, 2011-09-30 at 12:32 +0300, Tanu Kaskinen wrote:
> [...]
>> I'm not against making the comments wider. What width would you be happy
>> with? 100? I propose that something like the following is added to the
>> CodingStyle document so that there won't be any bikeshedding in the
>> future regarding this issue:
>>
>> "The recommended maximum line length of 128 is a bit much for comments.
>> Comments should be wrapped at X characters. If you prefer, comments with
>> only few lines can also use shorter line length, but in order to
>> conserve vertical space, very long comments should always be wrapped at
>> X characters."
>>
>> The latter sentence is there, because I think it reflects the current
>> practice, but it would be ok to me if the second sentence would be
>> dropped, and the recommendation would be to always wrap at X characters.
>>
>> What do others think? Is 100 the best number? Or 80? Or 89?
> 
> I'm fine with 80, tbh.

I'm not particularly bothered but 80 has always sat well with me just
because that's the kinda traditional marker (and the faint line that's
printed in my editor too - although that is obviously configurable).

I don't really mind either way tho'.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/



More information about the pulseaudio-discuss mailing list