[pulseaudio-discuss] [PATCH] alsa-sink/source: Really set volumes on port change

[Jyri Sarha]

On Wed, 04 Apr 2012 14:39:39 +0200, David Henningsson
<david.henningsson at canonical.com> wrote:
> On 04/03/2012 09:42 PM, David Henningsson wrote:
>> If deferred volumes were activated, set_volume does not really set
>> the volume, and is probably only meant to be called from the main
>> thread.
>> As we're currently really setting the port and the mute here (i e
>> modifying ALSA), we should really modify the volume as well.
>>
>> Signed-off-by: David Henningsson<david.henningsson at canonical.com>
> 
> Colin and Arun gave it a quick review and thought it made sense, and 
> I've tested it here and it seems to fix things and not break them, so 
> pushed now.
> 

Hi,
After giving this a quick look the patch looks Ok to me. However, the
comment for set_port call-back in src/pulsecore/sink.h should be update 
to something like this:

    /* Called whenever the port shall be changed. Called from IO thread
     * if PA_SINK_DEFERRED_VOLUME flag is set otherwise from main loop 
     * context.
     */

Cheers,
Jyri