[pulseaudio-discuss] [PATCH] dbus: fix dbus argument type in iface-stream.c handle_move() (fwd)

[Tanu Kaskinen]

On Tue, 2012-04-17 at 10:17 +0200, Peter Meerwald wrote:
> Hello Tanu,
> 
> can you please have a look at below patch/bug report?
> 
> I'm trying to move a stream from one device to another using dbus; I 
> think the parameter types do not match between the API and the C implementation

The patch is good. I'll push it today when I get home. Thanks!

-- 
Tanu

> ---------- Forwarded message ----------
> Date: Fri,  6 Apr 2012 11:44:57 +0200
> From: Peter Meerwald <pmeerw at pmeerw.net>
> Reply-To: General PulseAudio Discussion
>     <pulseaudio-discuss at lists.freedesktop.org>
> To: General PulseAudio Discussion <pulseaudio-discuss at lists.freedesktop.org>
> Cc: Peter Meerwald <p.meerwald at bct-electronic.com>
> Subject: [pulseaudio-discuss] [PATCH] dbus: fix dbus argument type in
>     iface-stream.c handle_move()
> 
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
> 
> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48376
> Signed-off-by: Peter Meerwald <p.meerwald at bct-electronic.com>
> ---
>  src/modules/dbus/iface-stream.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/modules/dbus/iface-stream.c b/src/modules/dbus/iface-stream.c
> index ecd0ff3..c6dc1c9 100644
> --- a/src/modules/dbus/iface-stream.c
> +++ b/src/modules/dbus/iface-stream.c
> @@ -611,7 +611,7 @@ static void handle_move(DBusConnection *conn, DBusMessage *msg, void *userdata)
>      pa_assert(msg);
>      pa_assert(s);
>  
> -    pa_assert_se(dbus_message_get_args(msg, NULL, DBUS_TYPE_STRING, &device, DBUS_TYPE_INVALID));
> +    pa_assert_se(dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH, &device, DBUS_TYPE_INVALID));
>  
>      if (s->type == STREAM_TYPE_PLAYBACK) {
>          pa_sink *sink = pa_dbusiface_core_get_sink(s->core, device);