[pulseaudio-discuss] [PATCH] echo-cancel: Drop the correct amount of samples when skipping.

Peter Meerwald pmeerw at pmeerw.net
Wed Apr 25 01:45:01 PDT 2012


Hello Tanu,

> ---
>  src/modules/echo-cancel/module-echo-cancel.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I am wondering how you came up with these echo-cancel related patches?
are there concrete issues you are fixing, is it code reading/review?

is there some regression testing in place? the EC module is big and 
non-trivial

what is the situation where this problem triggers?

I am not complaining about a specific patch you submitted, just concerned 
about the testability of the EC stuff

regards, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)


More information about the pulseaudio-discuss mailing list