[pulseaudio-discuss] [PATCH] resampler: Fix volume on downmix to mono

David Henningsson david.henningsson at canonical.com
Thu Aug 9 05:15:02 PDT 2012


On 08/09/2012 02:06 PM, Peter Meerwald wrote:
>> Patch credit: kwanghui
>>
>> When downmixing to mono, we should average the signal instead of
>> summing it to avoid clipping.
>
>> Anyone against me committing this one?
>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 7f947bd..2913319 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -228,7 +228,6 @@ TESTS_default = \
>>   		memblockq-test \
>>   		channelmap-test \
>>   		thread-mainloop-test \
>> -		utf8-test \
>
> this seems unrelated?!

See! That's why we have reviews. I was just checking if you were awake ;-)

...or at least more awake than I... :-/

Btw, I forgot to say. I also have that utf8-test does not compile 
problem. In case anyone wonders. :-)

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list