[pulseaudio-discuss] [PATCH 3/3] bluetooth: Don't force any profile on discovery module

Mikel Astiz mikel.astiz.oss at gmail.com
Fri Aug 17 08:02:31 PDT 2012


Hi Luiz,

On Fri, Aug 17, 2012 at 4:21 PM, Luiz Augusto von Dentz
<luiz.dentz at gmail.com> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz at intel.com>
>
> Let device module figure out the priority based on the state of the
> profiles.
>
> Note that most likely all profiles will be in PA_BT_AUDIO_STATE_CONNECTED
> state so 'Off' will be the initial profile then it is up to the policy
> module to switch to the most suitable profile.
> ---
>  src/modules/bluetooth/module-bluetooth-discover.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/src/modules/bluetooth/module-bluetooth-discover.c b/src/modules/bluetooth/module-bluetooth-discover.c
> index d4e056e..cddb21c 100644
> --- a/src/modules/bluetooth/module-bluetooth-discover.c
> +++ b/src/modules/bluetooth/module-bluetooth-discover.c
> @@ -107,11 +107,6 @@ static pa_hook_result_t load_module_for_device(pa_bluetooth_discovery *y, const
>                  args = tmp;
>              }
>
> -            if (d->hfgw_state >= PA_BT_AUDIO_STATE_CONNECTED)
> -                args = pa_sprintf_malloc("%s profile=\"hfgw\"", args);
> -            else if (d->audio_source_state >= PA_BT_AUDIO_STATE_CONNECTED)
> -                args = pa_sprintf_malloc("%s profile=\"a2dp_source\" auto_connect=no", args);
> -
>              pa_log_debug("Loading module-bluetooth-device %s", args);
>              m = pa_module_load(u->module->core, "module-bluetooth-device", args);
>              pa_xfree(args);

Ack from my side. Additionally, there is a "#if 0" block handling
profile argument as well, so we could drop it too.

Cheers,
Mikel


More information about the pulseaudio-discuss mailing list