[pulseaudio-discuss] [PATCH v0 16/20] bluetooth: Remove profile argument from bluetooth-device

[Luiz Augusto von Dentz]

Hi Mikel,

On Wed, Aug 22, 2012 at 11:08 AM, Mikel Astiz <mikel.astiz.oss at gmail.com> wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
>
> Remove the support to define a specific profile in the argument list,
> since the selection of the profile should be handled after the module
> has been loaded.
> ---
>  src/modules/bluetooth/module-bluetooth-device.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c
> index efa06fa..7d379f1 100644
> --- a/src/modules/bluetooth/module-bluetooth-device.c
> +++ b/src/modules/bluetooth/module-bluetooth-device.c
> @@ -74,7 +74,6 @@ PA_MODULE_USAGE(
>          "source_name=<name for the source> "
>          "source_properties=<properties for the source> "
>          "address=<address of the device> "
> -        "profile=<a2dp|hsp|hfgw> "
>          "rate=<sample rate> "
>          "channels=<number of channels> "
>          "path=<device object path> "
> @@ -93,7 +92,6 @@ static const char* const valid_modargs[] = {
>      "source_name",
>      "source_properties",
>      "address",
> -    "profile",
>      "rate",
>      "channels",
>      "path",
> @@ -2241,7 +2239,6 @@ static int add_card(struct userdata *u, const pa_bluetooth_device *device) {
>      enum profile *d;
>      const char *ff;
>      char *n;
> -    const char *default_profile;
>
>      pa_assert(u);
>      pa_assert(device);
> @@ -2343,13 +2340,6 @@ static int add_card(struct userdata *u, const pa_bluetooth_device *device) {
>      *d = PROFILE_OFF;
>      pa_hashmap_put(data.profiles, p->name, p);
>
> -    if ((default_profile = pa_modargs_get_value(u->modargs, "profile", NULL))) {
> -        if (pa_hashmap_get(data.profiles, default_profile))
> -            pa_card_new_data_set_profile(&data, default_profile);
> -        else
> -            pa_log_warn("Profile '%s' not valid or not supported by device.", default_profile);
> -    }
> -
>      u->card = pa_card_new(u->core, &data);
>      pa_card_new_data_done(&data);
>
> --
> 1.7.7.6
>

I would leave this, it may still be useful in case someone loads the
module manually without module-bluetooth-discovery.

-- 
Luiz Augusto von Dentz