[pulseaudio-discuss] [PATCH next v1 00/13] bluetooth: Abstract D-Bus inside bluetooth-util

Tanu Kaskinen tanuk at iki.fi
Sat Dec 15 20:49:25 PST 2012


On Fri, 2012-12-14 at 15:14 +0100, Mikel Astiz wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
> 
> v1 includes the changes pointed out by Tanu, most significantly:
> - Function naming fixes.
> - Transport owner (bus name) considered for SetProperty().
> - Traces improved.
> - Use pa_dbus_append_basic_variant() to simplify code.
> - pa_transport_is_acquired() refactored.
> 
> From original cover-letter:
> 
> This patchset moves all D-Bus dependencies from module-bluetooth-device into bluetooth-util, with the following two goals:
> (a) Make it easier to implement policy modules, because they would use the same information/API that module-bluetooth-device is using.
> (b) Make the transition to BlueZ 5 easier, because the D-Bus details are handled inside bluetooth-util.
> 
> The approach is very transport-centric, following the design ideas in BlueZ 5: profile-states are represented in the transport state, the volume control is associated to a transport, etc.
> 
> Mikel Astiz (13):
>   bluetooth: Abstract microphone gain in transport
>   bluetooth: Abstract speaker gain in transport
>   bluetooth: Use bluetooth-util for mic/speaker gain control
>   bluetooth: Move profile_to_string() to bluetooth-util
>   bluetooth: Refactor parsing of profile state changes
>   bluetooth: Use transport state to update port availability
>   bluetooth: Abstract transport access types inside bluetooth-util
>   bluetooth: Trivially remove bt_transport_is_acquired()
>   bluetooth: Refactor dependency to org.bluez.Audio
>   bluetooth: Use transport state instead of profile states
>   bluetooth: Remove D-Bus dependency in module-bluetooth-device
>   bluetooth: Call setup_stream() manually
>   bluetooth: Replace acquire param 'start' with 'optional'
> 
>  src/modules/bluetooth/bluetooth-util.c          | 152 +++++++-
>  src/modules/bluetooth/bluetooth-util.h          |  14 +-
>  src/modules/bluetooth/module-bluetooth-device.c | 462 ++++++++----------------
>  3 files changed, 314 insertions(+), 314 deletions(-)

Thank you! All patches applied.

-- 
Tanu



More information about the pulseaudio-discuss mailing list