[pulseaudio-discuss] [PATCH] qpaeq: Try to load equalizer module before failing, better error messages

Tanu Kaskinen tanuk at iki.fi
Sat Dec 15 22:16:51 PST 2012


On Tue, 2012-07-10 at 21:05 +0200, Matěj Laitl wrote:
> On 6. 7. 2012 Tanu Kaskinen wrote:
> > On Sun, 2012-03-25 at 16:47 +0200, Matěj Laitl wrote:
> > > On 23. 3. 2012 Colin Guthrie wrote:
> > > > As it's a GUI program that could be started via a menu or .desktop file,
> > > > it would be nice to warn the user via a GUI friendly way when things go
> > > > really wrong.
> > > >
> > > > That would be a good next step if you are keen!
> > >
> > > Okay, I will do this later, with one obvious caveat that we cannot show
> > > "Qt  not found" dialog using Qt.
> > 
> > What are your plans regarding this? Should we wait for an improved
> > patch, or should the first version be merged?
> 
> Please do merge the first version, any work can be applied on top of it.

Sorry for the ridiculous delay... The patch has now been applied to my
"next" branch. Thank you for the contribution!

> > > Also, it seem that we don't ship .desktop file for qpaeq, should we?
> > 
> > I guess it wouldn't at least do any harm.
> 
> Will try. I don't know how the .desktop file translation is done in pulseaudio, 
> is it automatic as in KDE, for example?

You create foo.desktop.in and prefix translatable fields with an
underscore. We have @INTLTOOL_DESKTOP_RULE@ src/Makefile.am, which I
think takes care of the rest of the translation stuff. foo.desktop.in
should be put somewhere in src/Makefile.am too, maybe in EXTRA_DIST. I
don't know if there are some other details to be taken care of.

-- 
Tanu



More information about the pulseaudio-discuss mailing list