[pulseaudio-discuss] [PATCH] pulse: Fix old bug in stream_free

[Tanu Kaskinen]

On Wed, 2012-02-15 at 02:09 +0100, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst<m.b.lankhorst at gmail.com>
> 
> ---
> Derp, should be backported to stable distro versions too, found out after testing my winepulse
> with wine's mmdevapi tests.
> 
> diff --git a/src/pulse/stream.c b/src/pulse/stream.c
> index 0a96ced..6115cef 100644
> --- a/src/pulse/stream.c
> +++ b/src/pulse/stream.c
> @@ -284,8 +284,9 @@ static void stream_free(pa_stream *s) {
>       stream_unlink(s);
> 
>       if (s->write_memblock) {
> -        pa_memblock_release(s->write_memblock);
> -        pa_memblock_unref(s->write_data);
> +        if (s->write_data)
> +            pa_memblock_release(s->write_memblock);
> +        pa_memblock_unref(s->write_memblock);
>       }
> 
>       if (s->peek_memchunk.memblock) {

Thanks a lot! I've pushed this now.

Btw, the indentation of the non-changed lines is for some reason 5
spaces, which caused some trouble when applying the patch
(--ignore-whitespace saved the day). I don't know if it's in my end or
yours, but something is broken somewhere... FWIW, other patches appear
to be fine, so it's probably something in your end.

-- 
Tanu