[pulseaudio-discuss] [PATCH 1/4] core: add ARM NEON optimized mono-to-stereo remapping code to build

[Rémi Denis-Courmont]

On Thu, 12 Jan 2012 17:20:06 +0100, Peter Meerwald <pmeerw at pmeerw.net>
wrote:
> +void pa_remap_func_init_neon(pa_cpu_arm_flag_t flags) {
> +#if defined (__ARM_NEON__)
> +
> +#ifdef RUN_TEST
> +    run_test_float();
> +    run_test_s16();
> +#endif
> +
> +    if (flags & PA_CPU_ARM_NEON) {
> +        pa_log_info("Initialising ARM NEON optimized remappers.");
> +        pa_set_init_remap_func((pa_init_remap_func_t) init_remap_neon);
> +    }

This blob does not seem to make much sense. If __ARM_NEON__ is defined,
then the compiler assumes NEON is supported. So a run-time check is silly.

> +
> +#endif /* defined (__ARM_NEON__) */
> +}

-- 
Rémi Denis-Courmont
http://www.remlab.net/