[pulseaudio-discuss] commit: resampler: Move some peak resampler asserts around

[Tanu Kaskinen]

On Wed, 2011-12-21 at 23:39 +0100, Maarten Bosmans wrote:
> This commit:
> http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=dc8edf4b43bf20e9edf6efd31836218924fad1f0
> 
> resampler: Move some peak resampler asserts around
> This moves a couple of asserts from peak_resample() to peaks_init()
> since they're resampler parameters that shouldn't change after
> initialisation.
> 
> is wrong IMHO.

This thread didn't reach any consensus. The change that you complained
about supposedly fixed [1], but from your message I get the impression
that the assertions were correct to begin with, so apparently the real
bug behind the crash has been now only hidden by moving the assertions
to a different place. Is that correct? Should the bug be reopened?

[1] https://bugs.freedesktop.org/show_bug.cgi?id=43694

-- 
Tanu