[pulseaudio-discuss] [PATCH] card-restore: Handle reading NULL profile name from the database.
Tanu Kaskinen
tanuk at iki.fi
Fri Jul 6 02:51:11 PDT 2012
On Sat, 2012-06-30 at 13:00 +0300, Tanu Kaskinen wrote:
> It's assumed in a couple of places that entry_read()
> initializes entry->profile to a non-NULL string. This patch
> makes those assumptions hold.
> ---
> src/modules/module-card-restore.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/modules/module-card-restore.c b/src/modules/module-card-restore.c
> index 1079a72..8f9434a 100644
> --- a/src/modules/module-card-restore.c
> +++ b/src/modules/module-card-restore.c
> @@ -199,6 +199,9 @@ static struct entry* entry_read(struct userdata *u, const char *name) {
> goto fail;
> }
>
> + if (!profile)
> + profile = "";
> +
> e->profile = pa_xstrdup(profile);
>
> if (!pa_tagstruct_eof(t))
I've now pushed this without review, because the change is simple and
Mikel Astiz tested that the patch works (unlike Mikel, I haven't seen
the crash myself). Thanks, Mikel, for testing!
--
Tanu
More information about the pulseaudio-discuss
mailing list