[pulseaudio-discuss] Add a single "On" profile to coreaudio devices. Fixes crash on OS X.

Tanu Kaskinen tanuk at iki.fi
Sun Jul 8 08:38:38 PDT 2012


On Sun, 2012-07-08 at 17:32 +0200, Paul Menzel wrote:
> Dear Sjors,
> 
> 
> thank you for your patch.
> 
> 
> Am Samstag, den 07.07.2012, 15:22 +0200 schrieb Sjors Gielen:
> 
> > Since commit 12af302a last month, cards always have at least one
> > profile, so there is also always an active_profile (this makes the code
> > more simple). However, module-coreaudio-device did not create a profile
> > yet, causing a crash of PulseAudio when used on OS X. This patch fixes
> > this crash, by adding a single "On" profile. I've also added a TODO for
> > adding an "Off" profile which removes all sinks and sources -- I can
> > work on resolving this TODO later on.
> 
> could you please resent the patch as `[PATCH v2]` and put the
> explanation above in the commit message. You can do that with `git
> commit --amend`.
> 
> Using Thunderbird please turn off line wrapping and just past the output
> of `git format-patch -1` into the message body and adapt the header
> appropriately.

Or use git send-email. It's very nice.

-- 
Tanu



More information about the pulseaudio-discuss mailing list