[pulseaudio-discuss] [PATCH v2] Add a single "On" profile to coreaudio devices. Fixes crash on OS X.

Tanu Kaskinen tanuk at iki.fi
Mon Jul 9 00:36:59 PDT 2012


On Sun, 2012-07-08 at 23:24 +0200, Sjors Gielen wrote:
> Since commit 12af302a last month, cards always have at least one
> profile, so there is also always an active_profile (this makes the code
> more simple). However, module-coreaudio-device did not create a profile
> yet, causing a crash of PulseAudio when used on OS X. This patch fixes
> this crash, by adding a single "On" profile. I've also added a TODO for
> adding an "Off" profile which removes all sinks and sources -- I can
> work on resolving this TODO later on.

Thanks! I've pushed the patch. I added "osx: " prefix to the commit
message, and removed the pa_card_new_data_set_profile(&card_new_data,
"on") call. Selecting the initial card profile should only be done by
policy modules (setting it in coreaudio-device prevents the policy
modules from working, because they won't alter the profile if it's
already set). If it's not set at all, the highest priority profile will
automatically be selected, so leaving the profile unselected is fine.

-- 
Tanu



More information about the pulseaudio-discuss mailing list