[pulseaudio-discuss] [PATCH] tests: enable to test standalone pulseaudio daemon

[rong deng]

2012/7/23 Arun Raghavan <arun.raghavan at collabora.co.uk>:
> On Thu, 2012-07-19 at 16:50 +0800, Deng Zhengrong wrote:
>> With this fix, `check-daemon` doesn't need a system-wide running pulseaudio
>> anymore.
>>
>> The method to use is to invoke `make check-daemon` under `src/` and it just
>> works! :)
>> ---
>>  src/Makefile.am          |    4 +-
>>  src/tests/test-daemon.sh |   61 ++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 63 insertions(+), 2 deletions(-)
>>  create mode 100755 src/tests/test-daemon.sh
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 4f6bd4f..39e1373 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -302,11 +302,11 @@ TESTS = $(TESTS_default)
>>  if BUILD_TESTS_DEFAULT
>>  noinst_PROGRAMS = $(TESTS_default) $(TESTS_norun) $(TESTS_daemon)
>>  else
>> -check_PROGRAMS = $(TESTS_default) $(TESTS_norun) $(TESTS_daemon)
>> +check_PROGRAMS = $(TESTS_default) $(TESTS_norun)
>>  endif
>>
>>  check-daemon:
>> -     $(MAKE) check TESTS="$(TESTS_daemon)"
>> +     $(top_builddir)/src/tests/test-daemon.sh
>
> I'd like to pass the list of tests kept in the Makefile with the script
> just executing them all (maybe you could just pass them in on the
> command line and iterate over $@). The rationale is that the rest of the
> test lists are in Makefile.am, so keeping it all in the same place makes
> tracking things later simpler.

Yes, you're right, I'll pass these tests as the parameter for the script.