[pulseaudio-discuss] [PATCH v1 2/4] bluetooth: Do not switch to profile unless Playing

[Luiz Augusto von Dentz]

Hi Mikel,

On Thu, Jul 26, 2012 at 3:32 PM, Mikel Astiz <mikel.astiz.oss at gmail.com> wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
>
> If no audio stream exists to the remote device during discovery,
> setting the profile to hfgw or a2dp_source would request it. This is
> something that should not be done automatically.
> ---
>  src/modules/bluetooth/module-bluetooth-discover.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/bluetooth/module-bluetooth-discover.c b/src/modules/bluetooth/module-bluetooth-discover.c
> index e96a4f3..6fe1334 100644
> --- a/src/modules/bluetooth/module-bluetooth-discover.c
> +++ b/src/modules/bluetooth/module-bluetooth-discover.c
> @@ -107,10 +107,10 @@ static pa_hook_result_t load_module_for_device(pa_bluetooth_discovery *y, const
>                  args = tmp;
>              }
>
> -            if (d->audio_source_state >= PA_BT_AUDIO_STATE_CONNECTED)
> +            if (d->audio_source_state >= PA_BT_AUDIO_STATE_PLAYING)
>                  args = pa_sprintf_malloc("%s profile=\"a2dp_source\" auto_connect=no", args);
>
> -            if (d->hfgw_state >= PA_BT_AUDIO_STATE_CONNECTED)
> +            if (d->hfgw_state >= PA_BT_AUDIO_STATE_PLAYING)
>                  args = pa_sprintf_malloc("%s profile=\"hfgw\"", args);
>
>              pa_log_debug("Loading module-bluetooth-device %s", args);

Im afraid this will cause more warm than good, the module being loaded
when connected means that we are able to control it before any stream
is created, this include setting up loopback and switching profiles.
Now regarding the problem of requesting the stream I though this would
be fixed by Acquire with '?', or this is a different matter?

-- 
Luiz Augusto von Dentz