[pulseaudio-discuss] [PATCH 1/2] add log category

[rong deng]

    diff --git a/src/daemon/caps.c b/src/daemon/caps.c
    index 3759388..49a0690 100644
    --- a/src/daemon/caps.c
    +++ b/src/daemon/caps.c
    @@ -20,6 +20,8 @@
       USA.
     ***/

    +#define PA_LOG_CATEGORY_DEFAULT "daemon"
    +


The above #define is duplicated below in various files.
Will it be better to have it #define'ed in a header file and inclued that
wherever required ?

[deng] Yes, I'll make "damon" a macro in log.h and then use something
similar to the below:
#DEFINE PA_LOG_CATEGORY_DEFAULT PA_LOG_CATEGORY_DAEMON

See previous comment, applies to above #define as well.
Please check all such occurrences below.

[deng] About the granularity of the category, I'm afraid I'm still in the
first stage which is to make it as simple as possible. e.g. bluetooth
module has different c files, and in the current implementation I make
different files into different categories, but yes, we can make it one big
category. We just need to reach a consensus on this one.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20120608/1e458873/attachment.html>