[pulseaudio-discuss] Duplicate content in libpulse and libpulsecommon

[Tanu Kaskinen]

On Sat, 2012-03-10 at 13:09 +0200, Tanu Kaskinen wrote:
> On Fri, 2012-03-09 at 10:26 +0000, Colin Guthrie wrote:
> > 'Twas brillig, and Tanu Kaskinen at 09/03/12 06:53 did gyre and gimble:
> > > I noticed that some parts of the public API are compiled twice: once as
> > > part of libpulse and once as part of libpulsecommon. Is there some
> > > wisdom in doing this that I'm unaware of? At least on my system things
> > > build and run fine also with the duplicates removed from libpulsecommon.
> > 
> > Does it build from a clean clone too?
> > 
> > I know there are very strange circular deps between the two libs, so my
> > only concern is that this double inclusion is needed to work around this.
> > 
> > But basically if it passes a make distcheck then I guess it should be fine!
> 
> It builds fine from a clean clone, and make distcheck passed after
> installing sshd (for ipacl-test) and fixing POTFILES. I've now pushed
> the patch.

The patch has been now reverted, it was causing problems with the
--as-needed linker option.
http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=bbc600aae9066ece6ed7802319669e3d00bdc095

-- 
Tanu