[pulseaudio-discuss] [PATCH] daemon: Initialize dbus to use thread-safe mode by default

[Tanu Kaskinen]

On Tue, 2012-03-13 at 00:30 +0100, David Henningsson wrote:
> On 03/13/2012 12:19 AM, Paul Menzel wrote:
> >> diff --git a/src/daemon/main.c b/src/daemon/main.c
> >> index 19933e3..3374196 100644
> >> --- a/src/daemon/main.c
> >> +++ b/src/daemon/main.c
> >> @@ -1066,6 +1066,11 @@ int main(int argc, char *argv[]) {
> >>       buf = pa_strbuf_new();
> >>
> >>   #ifdef HAVE_DBUS
> >> +    if (!dbus_threads_init_default()) {
> >> +        pa_log("dbus_threads_init_default() failed.");
> >
> > Is that going to be in the default log level output? If yes the message
> > should be more elaborate. Is there a place this is described? Or can
> > that only fail if the D-Bus configuration is totally messed up?
> 
> The latter. According to the bug comment this is likely only happening 
> on OOM.

According to the documentation it's not only "likely": OOM is the only
case where the function can fail. Because of this, I'd use
pa_assert_se(dbus_threads_init_default()).

-- 
Tanu