[pulseaudio-discuss] [PATCH] dbus: Remove a silly return statement.

[Colin Guthrie]

'Twas brillig, and Tanu Kaskinen at 23/03/12 07:49 did gyre and gimble:
> On Fri, 2012-03-23 at 09:46 +0200, Tanu Kaskinen wrote:
>> ---
>>  src/modules/dbus/iface-device.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/modules/dbus/iface-device.c b/src/modules/dbus/iface-device.c
>> index df64d36..97ccd91 100644
>> --- a/src/modules/dbus/iface-device.c
>> +++ b/src/modules/dbus/iface-device.c
>> @@ -604,7 +604,6 @@ static void handle_get_latency(DBusConnection *conn, DBusMessage *msg, void *use
>>      else if (d->type == PA_DEVICE_TYPE_SOURCE && !(d->source->flags & PA_SOURCE_LATENCY))
>>          pa_dbus_send_error(conn, msg, PA_DBUS_ERROR_NO_SUCH_PROPERTY,
>>                             "Source %s doesn't support latency querying.", d->source->name);
>> -    return;
>>  
>>      latency = (d->type == PA_DEVICE_TYPE_SINK) ? pa_sink_get_latency(d->sink) : pa_source_get_latency(d->source);
> 
> Sorry, I'm clearly not thinking what I'm doing. Please ignore this
> patch.
> 

Perhaps the remainder of the code should be commented out or at lease a
"header" comment after the return?

It certainly looks in the code like it's not meant to be there....

(either that or each if statement should be inside {} with it's own
individual return statements?)

Col



-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/