[pulseaudio-discuss] [PATCH] alsa-mixer: Fix element channel masks array size.
Tanu Kaskinen
tanu.kaskinen at digia.com
Mon Mar 26 04:56:38 PDT 2012
On Mon, 2012-03-26 at 13:44 +0200, David Henningsson wrote:
> On 03/26/2012 01:35 PM, Tanu Kaskinen wrote:
> > Valid channel id range is from 0 to SND_MIXER_SCHN_LAST,
> > inclusive, so the array size has to be
> > SND_MIXER_SCHN_LAST + 1.
>
> This looks correct. A quick grep for SND_MIXER_SCHN_LAST shows similar
> arrays in alsa-sink and alsa-source, and also, that my subset
> elimination goes up to SND_MIXER_SCHN_LAST exclusive. Maybe that should
> be changed at the same time?
Good spot! It seems that those arrays are unused, though, but maybe it
still makes sense to remove them in the same commit.
--
Tanu
More information about the pulseaudio-discuss
mailing list