[pulseaudio-discuss] [PATCH] pacmd: Added --help and --version descriptions to the man page.

[Tanu Kaskinen]

On Sun, 2012-05-06 at 16:10 +0200, poljar wrote:
> The pacmd man page should show the available options. A simple
> description for the --version and --help option was added.

Thanks! I totally forgot about the man page when you added the support
for those options. Good that you remembered it! A couple of trivial
mistakes are pointed out below, but I fixed those myself, so the patch
is now pushed.

> ---
>  man/pacmd.1.xml.in |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/man/pacmd.1.xml.in b/man/pacmd.1.xml.in
> index 079eb61..17ed828 100644
> --- a/man/pacmd.1.xml.in
> +++ b/man/pacmd.1.xml.in
> @@ -25,6 +25,8 @@ USA.
>  
>    <synopsis>
>      <cmd>pacmd</cmd>
> +    <cmd>pacat <opt>--help</opt></cmd>
> +    <cmd>pacat <opt>--version</opt></cmd>

The command name is wrong...

>    </synopsis>
>  
>    <description>
> @@ -40,6 +42,22 @@ USA.
>      <p>If any arguments are passed on the command line, they will be
>      passed into the live shell which will process the command and exit.</p>
>    </description>
> +  

This line has trailing whitespace. Didn't git warn you about it? For me
it refuses to commit changes with trailing whitespace. I don't remember
specifically configuring that, so I'd expect it to refuse committing
such changes for everybody, but maybe I have just forgotten that I have
configured that somehow...

-- 
Tanu