[pulseaudio-discuss] [PATCH 0/2] modules, pulse, core: React to failing pa_memblockq_push calls.
tanu.kaskinen at digia.com
Thu May 24 02:26:52 PDT 2012
On Thu, 2012-05-24 at 10:52 +0300, Tanu Kaskinen wrote:
> On Thu, 2012-05-24 at 10:38 +0300, Jarkko Suontausta wrote:
> > Based on Coverity findings, the return values of pa_memblockq_push and
> > pa_memblockq_push_align calls were not taken into account. These patches
> > are addressing many of those cases by adding an assertion.
> > Thanks to a thorough review of the first version, Tanu is already familiar
> > with the patches. He had many good proposals for the remaining FIXME cases,
> > but unfortunately I do not have time to address them now.
> For reference to other reviewers and also to myself, below is the first
> review (for the second patch - the first one looks good to me as is):
To clarify, that review is for an earlier version of the patch, so
please don't get confused when seeing code that doesn't match what
Jarkko posted on the mailing list.
More information about the pulseaudio-discuss