[pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Show the availability of the ports and profiles.

David Henningsson david.henningsson at canonical.com
Fri Nov 9 10:29:20 PST 2012


On 11/09/2012 07:17 PM, Tanu Kaskinen wrote:
> On Thu, 2012-11-08 at 23:38 +0100, poljar (Damir Jelić) wrote:
>> +        if (hasNo && !hasYes && !hasOther)
>> +            desc += " (unplugged)";
>> +        else if (hasYes && !hasNo && !hasOther)
>> +            desc += " (plugged in)";
>
> I think profiles should be "plugged in" if any port is available.

The reason I did it for profiles in the first place, were just to make 
the user get a hint about which one of the four HDMIs to select on the 
configuration tab, and there is just one port per profile in that scenario.

I also think that if one port is available and another is not, we 
shouldn't say that the entire profile is "plugged in". It really only 
makes sense to write something when all of the ports have the same 
value. I e, the current code is correct IMO.


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list