[pulseaudio-discuss] [RFC 1/2] bluetooth: Add MediaTransport volume management

Mikel Astiz mikel.astiz.oss at gmail.com
Tue Nov 13 23:13:47 PST 2012


Hi Frédéric,

On Mon, Nov 12, 2012 at 4:19 PM, Frédéric Danis
<frederic.danis at linux.intel.com> wrote:
> With BlueZ 5 volume updates for HFP will go through transport interface.
>
> Note that this is backward compatible.
> ---
>  src/modules/bluetooth/bluetooth-util.c          |   62 +++++++++++++++----
>  src/modules/bluetooth/bluetooth-util.h          |    4 ++
>  src/modules/bluetooth/module-bluetooth-device.c |   75 +++++++++++++++++++++++
>  3 files changed, 130 insertions(+), 11 deletions(-)
>

Without entering the patch details as already reviewed by Tanu, I have
a general question:

BlueZ 5 will rewrite the MediaTransport API to be following the
standard ObjectManager/Properties interfaces. This means the new API
will not be compatible with the current modules in PA. Don't you think
we should migrate to this new APIs first before adding new features to
PA?

I think you are already assuming that bluetooth-util will abstract the
specific BlueZ version (4.x vs 5.x) so that the modules don't have to
care much. I could agree with this assumption but I believe we should
implement this first.

Cheers,
Mikel


More information about the pulseaudio-discuss mailing list