[pulseaudio-discuss] [PATCH 0/3] rtp: Configurable source IP

[Tanu Kaskinen]

On Mon, 2012-11-19 at 17:46 +0530, Arun Raghavan wrote:
> On Sat, 2012-11-17 at 23:31 +0000, Robin H. Johnson wrote:
> > From: "Robin H. Johnson" <robbat2 at gentoo.org>
> > 
> > On a multi-homed system, the user may wish RTP to be used only on
> > specific interfaces. The default binding of 0.0.0.0 for the source
> > address causes SAP multicast on all interfaces, which is not ideal.
> > 
> > Introduce a new module argument, srcip, that allows selection of the
> > source IP, and thus interface.
> > 
> > Robin H. Johnson (3):
> >   rtp: Cleanup variable naming.
> >   rtp: rename modarg destination to dstip
> >   rtp: Introduce source IP configuration with srcip
> > 
> >  src/modules/rtp/module-rtp-send.c | 97 +++++++++++++++++++++++++++++----------
> >  1 file changed, 72 insertions(+), 25 deletions(-)
> 
> Thanks for the patches. I've pushed them with some minor changes
> (including the modarg names) to my 'next' branch. If they look okay to
> you, I'll push this out after we unfreeze (we are currently frozen for
> 3.0).
> 
> http://cgit.collabora.com/git/user/arun/pulseaudio.git/log/?h=next

Great, you did the same change to the modarg names as I would have done.
Only one small difference: I would have used underscore instead of
hyphen in "destination-ip" and "source-ip". Most (but not all) of
multi-word module arguments use underscore, so I think it makes sense to
be consistent in that regard.

-- 
Tanu