[pulseaudio-discuss] [PATCH v2 3/6] Proper poll() emulation to fix pacat and friends on windows.

Arun Raghavan arun.raghavan at collabora.co.uk
Tue Oct 23 23:30:50 PDT 2012


On Tue, 2012-10-23 at 11:42 +0200, Thomas Martitz wrote:
> Am 23.10.2012 08:40, schrieb Arun Raghavan:
> > On Mon, 2012-08-20 at 23:50 +0200, Thomas Martitz wrote:
> >> Currently, Windows versions of pacat and friends fail because the current
> >> poll emulation is not sufficient (it only works for socket fds).
> >>
> >> Luckily Gnulib has a much better emulation that seems to work perfect
> >> all over. The implementation has been largely copied (except a bug fix
> >> regarding timeout handling, to be pushed upstream) and works on pipes
> >> and files as well.
> >>
> >> This fixes the "Assertion (!e->dead) failed" error coming and lets pacat
> >> and friends stream happily to/from a server (I didn't actually test parec).
> >> ---
> > The changes look okay to me, but the gnulib code is GPL -- any chance
> > that the author would agree to a dual-license for this?
> 
> Actually, I took the copy from git[1], which has it under GPLv2 or later.
> 
> [1] https://github.com/git/git/blob/master/compat/poll/poll.c

Most of the PulseAudio server code is LGPL or more permissive (with the
exception of the speex resampler and Bluetooth proximity helper, which
are both optional). I'd rather not have to have an "except when
compiling for Windows" clause to our license if there is a choice. Do
you think the author might agree to an LGPL license?

-- Arun



More information about the pulseaudio-discuss mailing list