[pulseaudio-discuss] [PATCH] resampler: Make sure that there are no overflows when multiplying potentially big numbers.

Arun Raghavan arun.raghavan at collabora.co.uk
Mon Oct 29 20:17:04 PDT 2012

On Mon, 2012-07-09 at 10:07 +0300, Tanu Kaskinen wrote:
> This fixes at least one crash that has been observed. The
> multiplication in trivial_resample() overflowed when
> resampling from 96 kHz to 48 kHz, causing an assertion
> error:
> Assertion 'o_index * fz < pa_memblock_get_length(output->memblock)' failed at pulsecore/resampler.c:1521, function trivial_resample(). Aborting.
> Without the assertion, the memcpy() after the assertion
> would have overwritten some random heap memory.
> ---

Looks good, please go ahead and push this.

-- Arun

More information about the pulseaudio-discuss mailing list