[pulseaudio-discuss] [PATCH] resampler: Make sure that there are no overflows when multiplying potentially big numbers.
arun.raghavan at collabora.co.uk
Tue Oct 30 05:26:30 PDT 2012
On Tue, 2012-10-30 at 12:06 +0200, Tanu Kaskinen wrote:
> On Tue, 2012-10-30 at 08:47 +0530, Arun Raghavan wrote:
> > On Mon, 2012-07-09 at 10:07 +0300, Tanu Kaskinen wrote:
> > > This fixes at least one crash that has been observed. The
> > > multiplication in trivial_resample() overflowed when
> > > resampling from 96 kHz to 48 kHz, causing an assertion
> > > error:
> > >
> > > Assertion 'o_index * fz < pa_memblock_get_length(output->memblock)' failed at pulsecore/resampler.c:1521, function trivial_resample(). Aborting.
> > >
> > > Without the assertion, the memcpy() after the assertion
> > > would have overwritten some random heap memory.
> > > ---
> > Looks good, please go ahead and push this.
> Are you applying the patches when reviewing? If so, I think it's ok to
Nope, just reading the mail and replying. :)
More information about the pulseaudio-discuss