[pulseaudio-discuss] [PATCH v2 00/22] Revisiting Bluetooth modules

[Mikel Astiz]

Hi Arun,

On Wed, Sep 26, 2012 at 1:57 PM, Arun Raghavan
<arun.raghavan at collabora.co.uk> wrote:
> On Fri, 2012-08-31 at 12:50 +0200, Mikel Astiz wrote:
>> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
>>
>> This patchset revisits the mapping between Bluetooth (BT) and PulseAudio (PA) states, as well as how the PA infrastructure and APIs fit the BT use-cases, including desktop and IVI use-cases. The topic has already been discussed several times in the mailing-list and IRC.
>
> Thank you for the great work, and sorry it's taken so long to get to
> merging this!
>
>> Therefore, the updated grouping of the patches would be as follows:
>>
>> - Patches 1..9 propose minor changes, refactoring for later patches and some minor fixes (grouped in the beginning for readability).
>>
>> - Patches 10..15 implement the new proposal for module-bluetooth-device. This is the main contribution of the patchset.
>
> Pulled all of these to my tree and will push them out in a bit.
>
>> - Patches 16..21 focus on the integration with other modules.
>
> 18 and 19 are a no-go from me. I'm not okay with dependencies between
> unrelated modules. As mentioned on IRC a while back, I'd much rather
> signal an unwillingness to be suspended via sink/source flags.
>
> The alternative is we declare suspend-on-idle core, but tbh I think
> that's messier than just doing the flags.

I will think of alternative approaches but keep in mind that the
"unwillingness" is idle-specific, so adding these flags also sounds to
me like declaring suspend-on-idle core.

>> - Patch 22 is experimental and should not be applied yet.
>
> Luiz mentioned the patch for that version is in, so if you could just
> update the version on the comment (or even just tell me on IRC), I'll
> update and push that one too.

Let's discuss this with Luiz but I would rather leave it out. Even
though the patch is already applied in BlueZ, there has been no
release yet and chances are that the next release will take some time
and involve other changes.

Cheers,
Mikel