[pulseaudio-discuss] Updates to filtering work. Review requested.

Justin Chudgar justin at justinzane.com
Fri Apr 19 16:27:15 PDT 2013


Gentlemen, Ladies and Bots: 

Thanks again for all your help getting me to this point. Based on various 
input, I have done a major refactor of what was module-lfe-lp. The actual 
filtering code now lives in pulsecore/biquad-filter.c/h so that it may be used 
by other modules or by pulse itself. Module-lfe-lp has been renamed module-
lfe-lowpass-sink.c and now relies on biquad-filter to do the heavy lifting. 

I have tried to cleanup most of the fprint and comment cruft and have moved 
all doc comments to biquad-filter.h. You will note that I wrote the biquad code 
with the assumption that it will get extended to handle other filter types, 
like notch and bandpass, as well as 2nd, 4th, 6th and 8th order filtering. This 
is not used by my module, but it seemed logical to enable easy extension of 
functionality as needed.

I would appreciate your continued review and guidance. For your convenience, I 
attached a graph of the power spectral density comparison for a standard 
surround-51 setup with lpfreq=200.0Hz. To my uneducated eye, it looks like 
things are working.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_200.png
Type: image/png
Size: 61801 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20130419/b53145f7/attachment-0001.png>

More information about the pulseaudio-discuss mailing list