[pulseaudio-discuss] [PATCH] Improve the "set log functionality"

David Henningsson david.henningsson at canonical.com
Mon Apr 29 07:11:50 PDT 2013

On 04/20/2013 10:28 AM, Shuai Fan wrote:
> This patch is my first attempt to Improve the "set log functionality".
> Any suggestions?

Hi Shuai!

I'm not sure what kind of suggestions you're looking for, but first 
suggestion is to use "git send-email" to send your patches instead of 
attaching them, because that makes commenting easier.

Also, have you actually tested the code? It looks like it would set the 
log target for the pactl client, not the server which pactl connects to, 
which is quite unexpected.

Also, did you copy-paste pa_log_parse_target from somewhere else? If so 
you should make the old code use your new function.

> Best wishes,
>      Shuai
> 0001-Improve-set-log-target-functionality.patch

David Henningsson, Canonical Ltd.

More information about the pulseaudio-discuss mailing list