[pulseaudio-discuss] [PATCH 1/3] bluetooth: Add 'bluez.alias' property

[Mikel Astiz]

Hi Tanu,

On Mon, Apr 29, 2013 at 4:01 PM, Tanu Kaskinen <tanu.kaskinen at intel.com> wrote:
> On Fri, 2013-04-26 at 12:30 -0300, jprvita at gmail.com wrote:
>> From: João Paulo Rechi Vita <jprvita at openbossa.org>
>>
>> ---
>>
>> As already discussed with Tanuk and Mikel, this series should be applied to the
>> master branch.
>
> I don't remember there being any talk about pushing this series to the
> master branch. I will use next, unless you have a good reason why this
> needs to be in 4.0.

Sounds good.

>
>>
>>  src/modules/bluetooth/module-bluetooth-device.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c
>> index c877df2..8695c80 100644
>> --- a/src/modules/bluetooth/module-bluetooth-device.c
>> +++ b/src/modules/bluetooth/module-bluetooth-device.c
>> @@ -2243,6 +2243,7 @@ static int add_card(struct userdata *u) {
>>      pa_proplist_sets(data.proplist, "bluez.path", device->path);
>>      pa_proplist_setf(data.proplist, "bluez.class", "0x%06x", (unsigned) device->class);
>>      pa_proplist_sets(data.proplist, "bluez.name", device->name);
>> +    pa_proplist_sets(data.proplist, "bluez.alias", device->alias);
>
> device->alias is not guaranteed to be non-NULL, so this code can crash.
> If the Alias property is non-optional in Bluez, bluetooth-util should
> ensure that it is indeed always set.

BlueZ 4 API guarantees the property will be present, and therefore
device->alias should always be set. The obvious exception is BlueZ
misbehaving, but this condition might hold true for device->name as
well, which we're not checking either.

I don't think there's any other scenario where the alias could be NULL
and the name be set outside bluetooth-util.

So while your point is valid, I suggest we fix this in a later patch,
in a similar way that the BlueZ 5 patchset does (set device_info_valid
to -1 if any non-optional property is missing).

Cheers,
Mikel