[pulseaudio-discuss] [PATCH v2 04/19] modules: Fix resource leak in alsa-ucm

Peter Meerwald pmeerw at pmeerw.net
Thu Dec 19 03:11:33 PST 2013


From: Peter Meerwald <p.meerwald at bct-electronic.com>

https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8833&defectInstanceId=3732&mergedDefectId=591268

Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
---
 src/modules/alsa/alsa-ucm.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c
index c88fc77..23522c7 100644
--- a/src/modules/alsa/alsa-ucm.c
+++ b/src/modules/alsa/alsa-ucm.c
@@ -1106,8 +1106,7 @@ static void alsa_mapping_add_ucm_modifier(pa_alsa_mapping *m, pa_alsa_ucm_modifi
         m->description = pa_xstrdup(new_desc);
     pa_xfree(cur_desc);
 
-    if (!m->description)
-        pa_xstrdup("");
+    m->description = m->description ? m->description : pa_xstrdup("");
 
     /* Modifier sinks should not be routed to by default */
     m->priority = 0;
-- 
1.7.9.5



More information about the pulseaudio-discuss mailing list