[pulseaudio-discuss] [PATCH v2 00/19] coverity fixes

Peter Meerwald pmeerw at pmeerw.net
Thu Dec 19 03:11:29 PST 2013


From: Peter Meerwald <p.meerwald at bct-electronic.com>

updated fixes reported by Coverity, see http://scan.coverity.com
incorporating poljar's suggestions

many false-positive warnings due to pa_assert_se() reduced using
user_nodefs.h:
#nodef pa_assert_se(x) do { int y = x ; if (!(y)) __coverity_panic__(); } while (0)

Peter Meerwald (19):
  modules: Fix resource leak in stream-restore
  modules: Fix resource leak in alsa-card
  modules: Fix resource leak in device-restore
  modules: Fix resource leak in alsa-ucm
  modules: Fix resource leak in oss
  core: Fix resource leak in core-util
  modules: Fix resource leak in tunnel-sink-new
  modules: Fix resource leak in roap_client
  modules: Fix resource leak in card-restore
  core: Fix uninit pointer read in protocol-native
  modules: Fix uninit value in rtp-send
  core: Fix asserting command in protocol-native
  modules: Remove redundant code in virtual-surround-sink
  tests: Fix resource leak in sigbus-test
  core: Use after free in pa_sink_input_new_data_set_formats() and
    pa_source_output_new_data_set_formats()
  modules: Remove dead code in position-event-sounds
  core: Remove dead code in pa_mainloop_run()
  core: Fix check for io->output_event in enable_events()
  modules: Add assertion in equalizer-sink

 src/modules/alsa/alsa-ucm.c                |    3 +--
 src/modules/alsa/module-alsa-card.c        |   15 ++++++++++++---
 src/modules/module-card-restore.c          |    2 +-
 src/modules/module-device-restore.c        |    1 +
 src/modules/module-equalizer-sink.c        |    2 +-
 src/modules/module-position-event-sounds.c |    5 +----
 src/modules/module-stream-restore.c        |    4 +++-
 src/modules/module-tunnel-sink-new.c       |    6 ++++--
 src/modules/module-virtual-surround-sink.c |    2 --
 src/modules/oss/module-oss.c               |    2 ++
 src/modules/raop/raop_client.c             |    3 ++-
 src/modules/rtp/module-rtp-send.c          |    6 ++++++
 src/pulse/mainloop.c                       |    4 +---
 src/pulsecore/core-util.c                  |    8 ++++++--
 src/pulsecore/iochannel.c                  |    2 +-
 src/pulsecore/protocol-native.c            |    3 ++-
 src/pulsecore/sink-input.c                 |    2 +-
 src/pulsecore/source-output.c              |    2 +-
 src/tests/sigbus-test.c                    |    1 +
 19 files changed, 47 insertions(+), 26 deletions(-)

-- 
1.7.9.5



More information about the pulseaudio-discuss mailing list