[pulseaudio-discuss] [PATCH v2 16/19] modules: Remove dead code in position-event-sounds

Peter Meerwald pmeerw at pmeerw.net
Thu Dec 19 03:11:45 PST 2013


From: Peter Meerwald <p.meerwald at bct-electronic.com>

ma is always NULL in fail path, discovered by coverity

Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
---
 src/modules/module-position-event-sounds.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/modules/module-position-event-sounds.c b/src/modules/module-position-event-sounds.c
index 531fee7..3bcad6a 100644
--- a/src/modules/module-position-event-sounds.c
+++ b/src/modules/module-position-event-sounds.c
@@ -144,7 +144,7 @@ static pa_hook_result_t sink_input_fixate_hook_callback(pa_core *core, pa_sink_i
 }
 
 int pa__init(pa_module*m) {
-    pa_modargs *ma = NULL;
+    pa_modargs *ma;
     struct userdata *u;
 
     pa_assert(m);
@@ -165,9 +165,6 @@ int pa__init(pa_module*m) {
 fail:
     pa__done(m);
 
-    if (ma)
-        pa_modargs_free(ma);
-
     return -1;
 }
 
-- 
1.7.9.5



More information about the pulseaudio-discuss mailing list