[pulseaudio-discuss] [PATCH 00/13] coverity fixes

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Dec 20 03:19:35 PST 2013


On Fri, 2013-12-20 at 13:08 +0200, Tanu Kaskinen wrote:
> On Mon, 2013-12-16 at 18:20 +0100, Peter Meerwald wrote:
> > From: Peter Meerwald <p.meerwald at bct-electronic.com>
> > 
> > fix some issues shown by coverity
> > 
> > Peter Meerwald (13):
> >   modules: Fix resource leak in stream-restore
> >   modules: Fix resource leak in alsa-card
> >   modules: Fix resource leak in device-restore
> >   modules: Fix resource leak in alsa-ucm
> >   modules: Fix resource leak in oss
> >   core: Fix resource leak in core-util
> >   modules: Fix resource leak in tunnel-sink-new
> >   modules: Fix resource leak in roap_client
> >   modules: Fix resource leak in card-restore
> >   core: Fix uninit pointer read in protocol-native
> >   modules: Fix uninit value in rtp-send
> >   core: Fix asserting command in protocol-native
> >   modules: Remove redundant code in virtual-surround-sink
> > 
> >  src/modules/alsa/alsa-ucm.c                |    3 ---
> >  src/modules/alsa/module-alsa-card.c        |   15 ++++++++++++---
> >  src/modules/module-card-restore.c          |    2 +-
> >  src/modules/module-device-restore.c        |    1 +
> >  src/modules/module-stream-restore.c        |    4 +++-
> >  src/modules/module-tunnel-sink-new.c       |    6 ++++--
> >  src/modules/module-virtual-surround-sink.c |    2 --
> >  src/modules/oss/module-oss.c               |    2 ++
> >  src/modules/raop/raop_client.c             |    3 ++-
> >  src/modules/rtp/module-rtp-send.c          |    4 ++++
> >  src/pulsecore/core-util.c                  |    8 ++++++--
> >  src/pulsecore/protocol-native.c            |    3 ++-
> >  12 files changed, 37 insertions(+), 16 deletions(-)
> > 
> 
> Ack for all, except patch 4 that Damir already complained about, and
> patch 8 commit message has a typo: "roap_client" should be
> "raop_client".

Oh, I somehow missed the fact that you had already sent v2 of the patch
set. Ack for v2 too, except the typo is still there.

-- 
Tanu



More information about the pulseaudio-discuss mailing list