[pulseaudio-discuss] [PATCH] caps: Fix warnings.

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Mon Dec 30 08:57:47 PST 2013


On Wed, 2013-12-25 at 11:20 +0100, poljar (Damir Jelić) wrote:
> Since this commit: 1da34e99b203de14a45c94ec768faf04d41eca5b gcc was
> spewing out some warnings:
>     ../../src/daemon/caps.c:89:7: warning: "__FreeBSD__" is not defined [-Wundef]
>      #elif __FreeBSD__
>     ../../src/daemon/caps.c:92:11: warning: missing terminating ' character [enabled by default]
>       #error Don't know how to do capabilities on your system.  Please send a patch.
> 
> This patch fixes these two warnings.
> ---
>  src/daemon/caps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/daemon/caps.c b/src/daemon/caps.c
> index 7fc7357..ea095e8 100644
> --- a/src/daemon/caps.c
> +++ b/src/daemon/caps.c
> @@ -86,10 +86,10 @@ void pa_drop_caps(void) {
>      pa_assert_se(cap_clear(caps) == 0);
>      pa_assert_se(cap_set_proc(caps) == 0);
>      pa_assert_se(cap_free(caps) == 0);
> -#elif __FreeBSD__
> +#elif defined __FreeBSD__
>      pa_assert_se (cap_enter () == 0);
>  #else
> -#error Don't know how to do capabilities on your system.  Please send a patch.
> +#error "Don't know how to do capabilities on your system.  Please send a patch."
>  #endif /* __linux */
>  #else /* HAVE_SYS_CAPABILITY_H */
>      pa_log_warn("Normally all extra capabilities would be dropped now, but "

Sorry, I didn't notice your patch before I made a fix myself today:
http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=4c5ec015a4b33015114a66ec2f9c435ba8e41c7d

-- 
Tanu



More information about the pulseaudio-discuss mailing list