[pulseaudio-discuss] [PATCH 13/13] Remove refcounting from ports, sinks and sources

Tanu Kaskinen tanuk at iki.fi
Thu Feb 14 04:35:31 PST 2013


On Tue, 2013-02-12 at 21:37 +0200, Tanu Kaskinen wrote:
> A note about the removed pa_sink_ref() and pa_source_ref() calls in
> module-bluetooth-device: things probably break badly if the SCO sink
> or source is removed while being in the "SCO over PCM" mode, but I
> don't think that mode has ever worked properly if the SCO sink or
> source can disappear at runtime. On the systems that I know are
> using the "SCO over PCM" mode, the SCO devices stay loaded all the
> time. If this seems unacceptable, I can add some code to
> module-bluetooth-device to better track the SCO sink and source
> existence.

The patch has a bug regarding these removed ref() calls: the
corresponding unref() calls aren't removed. I'll send a fixed patch
after waiting some time for more feedback.

-- 
Tanu



More information about the pulseaudio-discuss mailing list