[pulseaudio-discuss] [PATCH 13/23] core: Remove duplicate stdio.h #include in sample-util.c

[Tanu Kaskinen]

On Wed, 2013-02-13 at 17:27 +0100, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
> ---
>  src/pulsecore/sample-util.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/pulsecore/sample-util.c b/src/pulsecore/sample-util.c
> index 26c0a01..bda5a5e 100644
> --- a/src/pulsecore/sample-util.c
> +++ b/src/pulsecore/sample-util.c
> @@ -24,7 +24,6 @@
>  #include <config.h>
>  #endif
>  
> -#include <stdio.h>
>  #include <string.h>
>  #include <stdlib.h>
>  #include <stdio.h>

About the commit title: at least in my opinion (I'm not sure about the
other maintainers), we shouldn't use "core:" prefix unless the commit
changes several files. You can use just "sample-util: Remove duplicate
stdio.h #include".

Similarly, there's no need to use two levels of prefixes when modifying
the mix.c code. Just "mix:" is enough.

-- 
Tanu