[pulseaudio-discuss] [PATCH 3/3] alsa-card: Make ELD monitor name a port property

[Tanu Kaskinen]

On Fri, 2013-02-15 at 13:42 +0100, David Henningsson wrote:
> If there is a proper monitor name, we expose this as a device.product.name
> property on the port. This can be useful for UIs who might want to show
> this name.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  src/modules/alsa/module-alsa-card.c |   33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c
> index 366f4ba..76da3a9 100644
> --- a/src/modules/alsa/module-alsa-card.c
> +++ b/src/modules/alsa/module-alsa-card.c
> @@ -309,6 +309,34 @@ static void init_profile(struct userdata *u) {
>              am->source = pa_alsa_source_new(u->module, u->modargs, __FILE__, u->card, am);
>  }
>  
> +static void reset_hdmi_eld_data(pa_device_port *p)
> +{

The convention is to not put the opening brace on its own line (this
same comment applies also to the previous patch, I didn't notice it at
first).

> +    /* Clear properties */
> +    pa_proplist_unset(p->proplist, PA_PROP_DEVICE_PRODUCT_NAME);

Hmm, we need pa_device_port_update_proplist() for sending change
notifications.

-- 
Tanu