[pulseaudio-discuss] [PATCHv3 3/3] echo-cancel: Warn on different sample rates for rec, play, out stream

Tanu Kaskinen tanuk at iki.fi
Mon Feb 18 09:21:37 PST 2013


On Mon, 2013-02-18 at 19:18 +0200, Tanu Kaskinen wrote:
> On Mon, 2013-02-18 at 16:31 +0100, Stefan Huber wrote:
> > The current echo-cancel framework does not support different sample
> > rates for the rec, play and out stream as it is assumed that the blocks
> > passed to the EC implementation's run() cover equal time spans. However,
> > pa__init() does not check that. Fix this.
> > ---
> >  src/modules/echo-cancel/module-echo-cancel.c |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> Applied, thanks.
> 
> > +    assert(source_output_ss.rate == source_ss.rate);
> > +    assert(sink_ss.rate == source_ss.rate);
> 
> I changed these to pa_assert().

Oops, I accidentally merged patch 3/3 with 2/3. Not much harm done, but
don't be surprised when the git log shows no commit for this patch.

-- 
Tanu



More information about the pulseaudio-discuss mailing list