[pulseaudio-discuss] [PATCH v0] bluetooth: Fix assertion failure if BlueZ crashes during GetProperties

[Tanu Kaskinen]

On Tue, 2013-02-19 at 16:12 +0100, Mikel Astiz wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
> 
> If BlueZ crashes exactly while PulseAudio waits for the GetProperties reply, the
> device has already been removed from the hashmap and therefore an assertion
> failure is experienced.
> 
> The solution consists of ignoring the reply in these cases.
> 
> The problem can be observed in the following traces:
> 
> D: [pulseaudio] bluetooth-util.c: Bluetooth daemon appeared.
> D: [pulseaudio] bluetooth-util.c: dbus: interface=org.bluez.Manager, path=/, member=AdapterAdded
> D: [pulseaudio] bluetooth-util.c: Adapter /org/bluez/497/hci1 created
> D: [pulseaudio] bluetooth-util.c: Registering /MediaEndpoint/HFPAG on adapter /org/bluez/497/hci1.
> D: [pulseaudio] bluetooth-util.c: Registering /MediaEndpoint/HFPHS on adapter /org/bluez/497/hci1.
> D: [pulseaudio] bluetooth-util.c: Registering /MediaEndpoint/A2DPSource on adapter /org/bluez/497/hci1.
> D: [pulseaudio] bluetooth-util.c: Registering /MediaEndpoint/A2DPSink on adapter /org/bluez/497/hci1.
> D: [pulseaudio] bluetooth-util.c: dbus: interface=org.bluez.Adapter, path=/org/bluez/497/hci1, member=DeviceCreated
> D: [pulseaudio] bluetooth-util.c: Device /org/bluez/497/hci1/dev_90_84_0D_B2_C7_04 created
> D: [pulseaudio] bluetooth-util.c: dbus: interface=org.freedesktop.DBus, path=/org/freedesktop/DBus, member=NameOwnerChanged
> D: [pulseaudio] bluetooth-util.c: Bluetooth daemon disappeared.
> E: [pulseaudio] bluetooth-util.c: Assertion 'p->call_data == d' failed at modules/bluetooth/bluetooth-util.c:685, function get_properties_reply(). Aborting.
> ---
>  src/modules/bluetooth/bluetooth-util.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Tanu