[pulseaudio-discuss] [PATCH] pavucontrol: add support for AAC pass-through

[Tanu Kaskinen]

On Fri, 2013-02-22 at 15:37 +0200, Tanu Kaskinen wrote:
> I'm afraid this is not good enough. One question is what happens if
> pavucontrol is compiled on a system with 4.0 headers, and run on a
> system with 3.0 libpulse? In that case you pass libpulse an encoding
> that it doesn't recognize. Well, it happens that libpulse doesn't
> validate the encoding values before sending them to the server, so
> there's no breakage. But it's still ugly to rely on the libpulse
> implementation details. I'd remove the check altogether and just depend
> on libpulse 4.0.

I changed my mind. Since the enumeration is extensible, it's fair to
expect libpulse not to try to limit the values to what were listed when
libpulse was built. So, no need to introduce a dependency to libpulse
4.0.

What I said about checking the protocol version still applies.

-- 
Tanu