[pulseaudio-discuss] [PATCH RFC 4/4] device-restore: Remove the ability to restore volumes for sinks.

[David Henningsson]

On 01/05/2013 12:19 AM, poljar (Damir Jelić) wrote:
> Volume saving/restoring for sinks is now provided by module-card-restore.

1) What about sources and
2) What about sinks/sources that don't have ports?

> ---
>   src/modules/module-device-restore.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/modules/module-device-restore.c b/src/modules/module-device-restore.c
> index 2a666ac..5504cb1 100644
> --- a/src/modules/module-device-restore.c
> +++ b/src/modules/module-device-restore.c
> @@ -775,6 +775,7 @@ static pa_hook_result_t sink_fixate_hook_callback(pa_core *c, pa_sink_new_data *
>
>       if ((e = perportentry_read(u, name, new_data->active_port))) {
>
> +        /*
>           if (u->restore_volume && e->volume_valid) {
>
>               if (!new_data->volume_is_set) {
> @@ -791,6 +792,7 @@ static pa_hook_result_t sink_fixate_hook_callback(pa_core *c, pa_sink_new_data *
>               } else
>                   pa_log_debug("Not restoring volume for sink %s, because already set.", new_data->name);
>           }
> +        */
>
>           if (u->restore_muted && e->muted_valid) {
>
>



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic