[pulseaudio-discuss] [PATCH 2/2] pactl: Show the default sink/source in the list command.

[Damir Jelić]

On Wed, Jan 30, 2013 at 02:05:29AM +0100, David Henningsson wrote:
> On 01/29/2013 05:41 PM, poljar (Damir Jelić) wrote:
> >This includes exposing the information in the protocol for the
> >get sink/source info commands and adding 2 new reply fields for
> >these commands.
> >
> >Update protocol to 28.
> >---
> >  PROTOCOL                        | 10 ++++++++++
> >  configure.ac                    |  2 +-
> >  src/modules/module-tunnel.c     | 10 ++++++++++
> >  src/pulse/introspect.c          | 14 ++++++++++++++
> >  src/pulse/introspect.h          |  2 ++
> >  src/pulsecore/protocol-native.c | 18 ++++++++++++++++++
> >  src/utils/pactl.c               |  4 ++++
> >  7 files changed, 59 insertions(+), 1 deletion(-)
> >
> >diff --git a/PROTOCOL b/PROTOCOL
> >index 01abeed..d0ea360 100644
> >--- a/PROTOCOL
> >+++ b/PROTOCOL
> >@@ -333,6 +333,16 @@ PA_COMMAND_GET_CARD_INFO(_LIST)):
> >
> >  The field is added once for every port.
> >
> >+## v28, implemented by >= 3.0
> 
> You probably mean >= 4.0 ?
> 
Oh, yeah you're right about that.

> Otherwise looks good (I did a quick read review only, no testing).
> 
> (Slightly cleaner to have the pactl changes in a separate patch but
> I'm not picky about that.)
> 

I wasn't even sure if we want to print that info since it's available
with 'pactl info' and I'm not sure if I should hide that info if the
protocol doesn't support this (if it's not supported it prints always
'no').

Thanks for the review.